absurdfarce commented on PR #2000: URL: https://github.com/apache/cassandra-java-driver/pull/2000#issuecomment-2593485597
Hmmm, okay, I didn't quite have my understanding of this right. My working assumption was that the shade plugin would _move_ the compiled class files to the new location rather than copy them. If you don't do this you potentially have duplication of class files if your build specified the original target directory (which would be common) as well as a new class directory created and added by the shade plugin. Under that scenario you wind up with missing class files either way; either the source files are missing from the original target directory because they were moved (by the shade plugin) or because they were deleted (by the clean plugin). If the shade plugin is only _copying_ files then yes, I agree with your analysis. Removing source files from the original target directory would trigger recompilation... which is exactly what we're seeing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
