frankgh commented on code in PR #172:
URL: https://github.com/apache/cassandra-sidecar/pull/172#discussion_r1912519674
##########
conf/sidecar.yaml:
##########
@@ -60,70 +60,74 @@ cassandra_instances:
sidecar:
host: 0.0.0.0
port: 9043
- request_idle_timeout_millis: 300000 # this field expects integer value
- request_timeout_millis: 300000
+ request_idle_timeout: 5m
+ request_timeout: 5m
tcp_keep_alive: false
accept_backlog: 1024
server_verticle_instances: 1
throttle:
stream_requests_per_sec: 5000
- timeout_sec: 10
+ timeout: 10s
traffic_shaping:
inbound_global_bandwidth_bps: 0 # 0 implies unthrottled, the
inbound bandwidth in bytes per second
outbound_global_bandwidth_bps: 0 # 0 implies unthrottled, the
outbound bandwidth in bytes per second
peak_outbound_global_bandwidth_bps: 419430400 # the peak outbound
bandwidth in bytes per second. The default is 400 mebibytes per second
- max_delay_to_wait_millis: 15000 # 15 seconds
- check_interval_for_stats_millis: 1000 # 1 second
+ max_delay_to_wait: 15s # 15 seconds
Review Comment:
I left the comments in place. I think it's fine to be extra verbose for the
configuration yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
