ekaterinadimitrova2 commented on code in PR #3696: URL: https://github.com/apache/cassandra/pull/3696#discussion_r1912237984
########## conf/jvm21-server.options: ########## @@ -0,0 +1,108 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +########################################################################### +# jvm21-server.options # +# # +# See jvm-server.options. This file is specific for Java 21 and newer. # +########################################################################### + +################# +# GC SETTINGS # +################# + + +### Generational ZGC settings +-XX:+UseZGC +-XX:+ZGenerational +# Temporary workaround for jamm's incorrect default CompressedOops; if you're using ZGC this needs to be set +-XX:-UseCompressedOops Review Comment: > i suspect it's more about providing the information as to why Yeah, consensus was the wrong word here. I agree with you. The same was done with G1GC, justifying its config as well and giving some direction to people who are about to use it. However, my other comment is that we should not change the config that will affect people who will still be on the previous Java versions with the other GC. (like in the Config class some defaults were changed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
