jmckenzie-dev commented on code in PR #3696:
URL: https://github.com/apache/cassandra/pull/3696#discussion_r1913737379
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -543,9 +543,12 @@ public static class SSTableConfig
public volatile DurationSpec.IntMinutesBound index_summary_resize_interval
= new DurationSpec.IntMinutesBound("60m");
@Replaces(oldName = "gc_log_threshold_in_ms", converter =
Converters.MILLIS_DURATION_INT, deprecated = true)
- public volatile DurationSpec.IntMillisecondsBound gc_log_threshold = new
DurationSpec.IntMillisecondsBound("200ms");
+ public volatile DurationSpec.IntMillisecondsBound gc_log_threshold = new
DurationSpec.IntMillisecondsBound("20s");
Review Comment:
Ah. So this was explicitly done for our internal build since we run ZGC only
on this release and the logging volume was roughly doubled w/the switch to ZGC.
Let me take a todo item to break out that threshold to offer a different value
we rely on in the ZGC case instead of hijacking the default shared value, thus
polluting the G1 / CMS cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
