michaelsembwever commented on code in PR #3696:
URL: https://github.com/apache/cassandra/pull/3696#discussion_r1912498900
##########
build.xml:
##########
@@ -45,7 +45,7 @@
The use of both CASSANDRA_USE_JDK11 and use-jdk11 is deprecated.
-->
<property name="java.default" value="11" />
- <property name="java.supported" value="11,17" />
+ <property name="java.supported" value="11,17,21" />
Review Comment:
> We just need to ensure we add it to CircleCI, which is still used by the
project.
I disagree. CircleCI is no longer needed in trunk, those that want to
continue to use it can at their own upkeep, but work shouldn't be blocked on
it. We can't hold the community hostage to having to support every CI system.
Note, my argument is _only_ to avoid the hard block here.
I do agree we should clearly indicate CircleCI jdk21 update isn't part of
this patch, create a ticket for it, and let those that want it jump in and
help. We should also start pushing for sponsors to run ci-cassandra.a.o clones
for the community to use for pre-commit runs. If we make these call outs then
I suspect this concern will prove to be trivial enough…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
