jmckenzie-dev commented on code in PR #3696: URL: https://github.com/apache/cassandra/pull/3696#discussion_r1913763578
########## conf/jvm-server.options: ########## @@ -174,6 +174,9 @@ #-Xms4G #-Xmx4G +# Need experimental bytebuddy for JDK21 +-Dnet.bytebuddy.experimental Review Comment: At the time when I first started working on this we _did_ need it. That may not be true now after some releases on the bytebuddy libs. Given it doesn't _hurt_ anything to have it there, I'm of a mind to leave it. @michaelsembwever - would you be interested in doing a run of ASFCI w/this removed to see if things still behave? I don't have internal upstreaming CI w/JDK21 support yet for the ASF code so can't easily run things internally. Wasn't too worried about that ordering since I assumed blocking merge on upstream CI working on JDK21, however to @ekaterinadimitrova2 's point in another comment, there's no reason we can't just merge this w/out formal support for it and have CI be on 11+17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
