smiklosovic commented on code in PR #3562: URL: https://github.com/apache/cassandra/pull/3562#discussion_r1915021822
########## src/java/org/apache/cassandra/cql3/constraints/ColumnConstraint.java: ########## @@ -89,5 +79,5 @@ public static int getSerializer(Class clazz) * * @return the Constraint type serializer */ - ConstraintsSerializers getConstraintType(); + ConstraintsSerializers getConstraintSerializerType(); Review Comment: I think it is really the way to go. You can have other usages of this enum where you have a bunch of `ColumnConstraint`'s and you want to know their types. What would you do? You would start to "instanceof"? So you call this method. But that method is called `getConstraintSerializerType`, which returns ... `ConstraintsSerializers`. Huh .. `ContraintType` goes beyond "serializers". It just happens to carried them too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org