bbotella commented on code in PR #3562:
URL: https://github.com/apache/cassandra/pull/3562#discussion_r1915004429
##########
src/java/org/apache/cassandra/cql3/constraints/ColumnConstraint.java:
##########
@@ -89,5 +79,5 @@ public static int getSerializer(Class clazz)
*
* @return the Constraint type serializer
*/
- ConstraintsSerializers getConstraintType();
+ ConstraintsSerializers getConstraintSerializerType();
Review Comment:
Not a super strong opinion on either of those. I choose to stay with the
`ConstraintSerializers` version for that reason, the values of that enum are
serializers. I'd rather keep it like this unless you really think
`ConstraintType` is the way to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
