jmckenzie-dev commented on PR #3562: URL: https://github.com/apache/cassandra/pull/3562#issuecomment-2596790078
Great work on this patch everyone; very impressed with it. I had a few follow up thoughts / questions after my 1st pass at review that I didn't add in the review comments: 1. in-jvm dtest: Mixed version clusters (some nodes older w/out feature, some with) 2. in-jvm dtest: Mixed _feature_ enabled clusters (some nodes with feature / constraints enabled, some without). i.e. a case where schema didn't propagate on a change or raced w/someone altering a table w/constraints. This one might not be necessary in a post-TCM world actually; happy to learn if so. :) 3. I don't recall seeing logic when I reviewed the patch to defer to a Guardrail being set in the event you tried to add a Constraint on that existing table. Did I miss that, or did we drop that (believe that was in the CEP) 4. Was there unit testing around the unprepared json additions for constraint checking and I missed that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
