Maxwell-Guo commented on code in PR #3562: URL: https://github.com/apache/cassandra/pull/3562#discussion_r1919574797
########## src/java/org/apache/cassandra/cql3/constraints/ColumnConstraints.java: ########## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3.constraints; + +import org.apache.cassandra.cql3.CqlBuilder; +import org.apache.cassandra.db.marshal.AbstractType; +import org.apache.cassandra.db.marshal.CompositeType; +import org.apache.cassandra.db.marshal.DynamicCompositeType; +import org.apache.cassandra.db.marshal.MapType; +import org.apache.cassandra.db.marshal.TupleType; +import org.apache.cassandra.db.marshal.UserType; +import org.apache.cassandra.io.IVersionedSerializer; +import org.apache.cassandra.io.util.DataInputPlus; +import org.apache.cassandra.io.util.DataOutputPlus; +import org.apache.cassandra.schema.ColumnMetadata; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Set; + +import com.google.common.collect.ImmutableSet; + +// group of constraints for the column +public class ColumnConstraints implements ColumnConstraint<ColumnConstraints> +{ + public static final Serializer serializer = new Serializer(); + public static final Noop NO_OP = new Noop(); + + private static final Set<Class<? extends AbstractType>> UNSUPPORTED_TYPES = ImmutableSet.of(MapType.class, + TupleType.class, + UserType.class, + CompositeType.class, + DynamicCompositeType.class); + + + + private final List<ColumnConstraint<?>> constraints; + private final int constraintsSize; + private final boolean isEmpty; + + public ColumnConstraints(List<ColumnConstraint<?>> constraints) + { + this.constraints = new ArrayList<>(constraints); + // These are catched values to avoid making the calculations every time + this.constraintsSize = constraints.size(); + this.isEmpty = constraints.isEmpty(); + } + + @Override + public IVersionedSerializer<ColumnConstraints> serializer() + { + return serializer; + } + + @Override + public void appendCqlTo(CqlBuilder builder) + { + for (ColumnConstraint<?> constraint : constraints) + constraint.appendCqlTo(builder); + } + + @Override + public void evaluate(Class<? extends AbstractType> valueType, Object columnValue) throws ConstraintViolationException + { + for (ColumnConstraint<?> constraint : constraints) + constraint.evaluate(valueType, columnValue); + } + + public List<ColumnConstraint<?>> getConstraints() + { + return constraints; + } + + public boolean isEmpty() + { + return isEmpty; + } + + public int getSize() + { + return constraintsSize; + } + + // Checks if there is at least one constraint that will perform checks + public boolean hasRelevantConstraints() + { Review Comment: what about change to ： ``` public boolean hasRelevantConstraints() { for (ColumnConstraint c : constraints) { if (c != ColumnConstraints.NO_OP) return true; } return false; } ``` ########## src/java/org/apache/cassandra/cql3/constraints/LengthConstraint.java: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.cql3.constraints; + +import com.google.common.collect.Sets; +import org.apache.cassandra.cql3.ColumnIdentifier; +import org.apache.cassandra.cql3.Operator; +import org.apache.cassandra.db.marshal.AbstractType; +import org.apache.cassandra.db.marshal.AsciiType; +import org.apache.cassandra.db.marshal.BytesType; +import org.apache.cassandra.db.marshal.Int32Type; +import org.apache.cassandra.db.marshal.UTF8Type; +import org.apache.cassandra.schema.ColumnMetadata; +import org.apache.cassandra.utils.ByteBufferUtil; + +import java.nio.ByteBuffer; +import java.util.Set; + +public class LengthConstraint implements ConstraintFunction +{ + public static final String FUNCTION_NAME = "LENGTH"; + private static final Set<Class<?>> SUPPORTED_TYPES = Sets.newHashSet(UTF8Type.class, + AsciiType.class, + BytesType.class); + + private final ColumnIdentifier columnName; + + public LengthConstraint(ColumnIdentifier columnName) + { + this.columnName = columnName; + } + + @Override + public String getName() + { + return FUNCTION_NAME; + } + + @Override + public void evaluate(Class<? extends AbstractType> valueType, Operator relationType, String term, Object columnValue) + { + int valueLength = getValueSize(columnValue, valueType); + int sizeConstraint = Integer.parseInt(term); + + ByteBuffer buffera = ByteBufferUtil.bytes(valueLength); + ByteBuffer bufferb = ByteBufferUtil.bytes(sizeConstraint); + + if (!relationType.isSatisfiedBy(Int32Type.instance, buffera, bufferb)) + throw new ConstraintViolationException(columnName + " does not satisfy lenght constraint. " + + valueLength + " should be " + relationType + ' ' + term); + } + + @Override + public void validate(ColumnMetadata columnMetadata) + { + Class<? extends AbstractType> valueType = columnMetadata.type.getClass(); + if (!SUPPORTED_TYPES.contains(valueType)) + throw invalidConstraintDefinitionException(valueType); + } + + private int getValueSize(Object value, Class<? extends AbstractType> valueType) + { + if (valueType == BytesType.class) + { + ByteBuffer bb = (ByteBuffer) value; + return bb.remaining(); + } + + if (valueType == AsciiType.class || valueType == UTF8Type.class) + return ((String) value).length(); + + throw invalidConstraintDefinitionException(valueType); + } + + private InvalidConstraintDefinitionException invalidConstraintDefinitionException(Class<? extends AbstractType> valueType) + { + throw new InvalidConstraintDefinitionException("Column type not supported. " + + "Supported types are " + SUPPORTED_TYPES + Review Comment: Exception message can be optimized: `` "Column type " + valueType + " is not supported, supported types are " + SUPPORTED_TYPES.`` ########## src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java: ########## @@ -764,7 +766,7 @@ final void addUpdates(UpdatesCollector collector, long nowInSeconds, Dispatcher.RequestTime requestTime) { - if (hasSlices()) + if (hasSlices()) // range deletion Review Comment: What is the relationship between the newly added "range deletion" and this patch ? ########## src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java: ########## @@ -153,6 +154,7 @@ public ModificationStatement(StatementType type, modifiedColumns = metadata.regularAndStaticColumns(); this.updatedColumns = modifiedColumns; + Review Comment: Please delete the newly added line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
