Maxwell-Guo commented on code in PR #3562:
URL: https://github.com/apache/cassandra/pull/3562#discussion_r1919492850
##########
src/java/org/apache/cassandra/schema/ColumnMetadata.java:
##########
@@ -609,6 +696,13 @@ public void serialize(ColumnMetadata t, DataOutputPlus
out, Version version) thr
out.writeBoolean(t.mask != null);
if (t.mask != null)
ColumnMask.serializer.serialize(t.mask, out, version);
+ if (version.isAtLeast(Version.V6))
Review Comment:
yes, after reading the source code, I found that I shouldn't have proposed
this.
##########
src/java/org/apache/cassandra/schema/ColumnMetadata.java:
##########
@@ -609,6 +696,13 @@ public void serialize(ColumnMetadata t, DataOutputPlus
out, Version version) thr
out.writeBoolean(t.mask != null);
if (t.mask != null)
ColumnMask.serializer.serialize(t.mask, out, version);
+ if (version.isAtLeast(Version.V6))
Review Comment:
> `t.columnConstraints` can't be null tho. It at least will be a Noop.
yes, after reading the source code, I found that I shouldn't have proposed
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
