Maxwell-Guo commented on code in PR #3562:
URL: https://github.com/apache/cassandra/pull/3562#discussion_r1919520168
##########
src/java/org/apache/cassandra/db/marshal/AbstractCompositeType.java:
##########
@@ -316,6 +320,53 @@ public <V> void validate(V input, ValueAccessor<V>
accessor)
}
}
+ @Override
+ public void checkConstraints(ByteBuffer input, ColumnConstraints
constraints) throws ConstraintViolationException
+ {
+ // no constraints defined for the partition keys
+ if (!constraints.hasRelevantConstraints())
+ return;
+
+ ValueAccessor<ByteBuffer> accessor = ByteBufferAccessor.instance;
+
+ boolean isStatic = readIsStatic(input, accessor);
+ int offset = startingOffset(isStatic);
+
+ int i = 0;
+ List<Object> partitionKeyValues = new ArrayList<>();
+ while (!accessor.isEmptyFromOffset(input, offset))
+ {
+ AbstractType<?> comparator = getComparator(i, input, accessor,
offset);
+ offset += getComparatorSize(i, input, accessor, offset);
+
+ int length = accessor.getUnsignedShort(input, offset);
+ offset += 2;
+
+ ByteBuffer value = accessor.slice(input, offset, length);
+ partitionKeyValues.add(comparator.compose(value));
+ offset += length;
+
+ accessor.getByte(input, offset++);
+ ++i;
+ }
+
+ if (partitionKeyValues.size() != constraints.getConstraints().size())
+ {
+ // contraints list should have the exact size of partition key
values.
+ // Noop constraints are filled for the partition key columns w/o
any constraints.
+ throw new IllegalStateException("Partition key values and number
of constraints do not match: "
Review Comment:
Partition key value number should be same with number of constraints
##########
src/java/org/apache/cassandra/cql3/constraints/LengthConstraint.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.cql3.constraints;
+
+import com.google.common.collect.Sets;
+import org.apache.cassandra.cql3.ColumnIdentifier;
+import org.apache.cassandra.cql3.Operator;
+import org.apache.cassandra.db.marshal.AbstractType;
+import org.apache.cassandra.db.marshal.AsciiType;
+import org.apache.cassandra.db.marshal.BytesType;
+import org.apache.cassandra.db.marshal.Int32Type;
+import org.apache.cassandra.db.marshal.UTF8Type;
+import org.apache.cassandra.schema.ColumnMetadata;
+import org.apache.cassandra.utils.ByteBufferUtil;
+
+import java.nio.ByteBuffer;
+import java.util.Set;
+
+public class LengthConstraint implements ConstraintFunction
+{
+ public static final String FUNCTION_NAME = "LENGTH";
+ private static final Set<Class<?>> SUPPORTED_TYPES =
Sets.newHashSet(UTF8Type.class,
+
AsciiType.class,
+
BytesType.class);
+
+ private final ColumnIdentifier columnName;
+
+ public LengthConstraint(ColumnIdentifier columnName)
+ {
+ this.columnName = columnName;
+ }
+
+ @Override
+ public String getName()
+ {
+ return FUNCTION_NAME;
+ }
+
+ @Override
+ public void evaluate(Class<? extends AbstractType> valueType, Operator
relationType, String term, Object columnValue)
+ {
+ int valueLength = getValueSize(columnValue, valueType);
+ int sizeConstraint = Integer.parseInt(term);
+
+ ByteBuffer buffera = ByteBufferUtil.bytes(valueLength);
+ ByteBuffer bufferb = ByteBufferUtil.bytes(sizeConstraint);
+
+ if (!relationType.isSatisfiedBy(Int32Type.instance, buffera, bufferb))
+ throw new ConstraintViolationException(columnName + " does not
satisfy lenght constraint. "
Review Comment:
nit: length ， not lenght
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
