dcapwell commented on code in PR #3785: URL: https://github.com/apache/cassandra/pull/3785#discussion_r1927757993
########## test/harry/main/org/apache/cassandra/harry/gen/ValueGenerators.java: ########## @@ -21,23 +21,29 @@ import java.util.Comparator; import java.util.List; -public class ValueGenerators +import org.apache.cassandra.harry.gen.Bijections.Bijection; + +public class ValueGenerators<PartitionKey, ClusteringKey> Review Comment: are you asking me to replace this with `ValueGenerators<P, C>`? or `ValueGenerators<PARTITION_KEY, CLUSTERING_KEY>`? Personally i see the "uppercase generic types" differently... almost always the type is `T`, `E`, `A`, etc... a single letter... and when working with types you should always start with a upper case letter... so what happens when the type isn't a single letter but a word? Then i follow the type rules which are camel case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
