dcapwell commented on code in PR #3785: URL: https://github.com/apache/cassandra/pull/3785#discussion_r1927753437
########## test/harry/main/org/apache/cassandra/harry/gen/BijectionCache.java: ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.harry.gen; + +import java.util.Comparator; +import java.util.Set; + +import com.google.common.collect.BiMap; +import com.google.common.collect.HashBiMap; + +import org.apache.cassandra.harry.MagicConstants; + +public class BijectionCache<T> implements Bijections.Bijection<T> Review Comment: Harry requires `descriptors` but not everything can cleanly fit into a `descriptor` (example: `1 + a.r`), in order to touch harry i need to fake descriptors... When you give a `ByteBuffer` for a column, we cache this and get a descriptor if its not present (hence the cache logic), and when harry looks up by descriptor this API works as it expects. If you ask for a `descriptor` that isn't first written to, we fail as its not in the cache... think of it more like a "pointer". In harry `descriptors` are more like random seeds, so you use them to construct the value... but there are a lot of cases that these tests touch that can't be expressed that way, so we can't create a value from an unknown `descriptor` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
