dcapwell commented on code in PR #3785: URL: https://github.com/apache/cassandra/pull/3785#discussion_r1927754694
########## test/harry/main/org/apache/cassandra/harry/gen/BijectionCache.java: ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.harry.gen; + +import java.util.Comparator; +import java.util.Set; + +import com.google.common.collect.BiMap; +import com.google.common.collect.HashBiMap; + +import org.apache.cassandra.harry.MagicConstants; + +public class BijectionCache<T> implements Bijections.Bijection<T> +{ + private final BiMap<T, Long> valueToDescriptor = HashBiMap.create(); + private final Comparator<? super T> comparator; + private long counter = 0; + + public BijectionCache(Comparator<? super T> comparator) + { + this.comparator = comparator; + } + + @Override + public T inflate(long descriptor) + { + T value = valueToDescriptor.inverse().get(descriptor); + if (value == null) + throw new IllegalArgumentException(String.format("Attempted to inflate %d, but it is undefined", descriptor)); + return value; + } + + @Override + public long deflate(T value) + { + if (value == null) + throw new NullPointerException("Attempted to deflate 'null'"); + if (valueToDescriptor.containsKey(value)) + return valueToDescriptor.get(value); + long d = counter++; + valueToDescriptor.put(value, d); + return d; + } + + public long deflateOrUndefined(T value) + { + return valueToDescriptor.containsKey(value) ? valueToDescriptor.get(value) : MagicConstants.UNSET_DESCR; + } + + public Set<Long> descriptors() + { + return valueToDescriptor.inverse().keySet(); + } + + public Set<T> values() + { + return valueToDescriptor.keySet(); + } + + public void release(Set<Long> toGC) Review Comment: its from the POC i had back at community over code... I created a load generator that ran against an accord cluster for days, which required me to add GC logic... given the load generator isn't present in this patch and we don't currently require GC for our tests, ill remove this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
