tolbertam commented on code in PR #2007:
URL:
https://github.com/apache/cassandra-java-driver/pull/2007#discussion_r1934073101
##########
core/src/main/java/com/datastax/oss/driver/internal/core/session/PoolManager.java:
##########
@@ -221,18 +222,23 @@ private void init(CqlIdentifier keyspace) {
stateEventFilter.start();
Collection<Node> nodes =
context.getMetadataManager().getMetadata().getNodes().values();
- List<CompletionStage<ChannelPool>> poolStages = new
ArrayList<>(nodes.size());
+ Map<Node, CompletionStage<ChannelPool>> poolStageByNode = new
HashMap<>(nodes.size());
for (Node node : nodes) {
NodeDistance distance = node.getDistance();
if (distance == NodeDistance.IGNORED) {
LOG.debug("[{}] Skipping {} because it is IGNORED", logPrefix, node);
} else if (node.getState() == NodeState.FORCED_DOWN) {
LOG.debug("[{}] Skipping {} because it is FORCED_DOWN", logPrefix,
node);
+ } else if (poolStageByNode.containsKey(node)) {
+ LOG.warn("[{}] Skipping {} because pool for it is already created",
logPrefix, node);
Review Comment:
Probably sufficient to use debug here :+1:
```suggestion
LOG.debug("[{}] Skipping {} because pool for it is already
created", logPrefix, node);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
