tolbertam commented on code in PR #2007:
URL:
https://github.com/apache/cassandra-java-driver/pull/2007#discussion_r1934186767
##########
core/src/main/java/com/datastax/oss/driver/internal/core/session/PoolManager.java:
##########
@@ -221,18 +222,23 @@ private void init(CqlIdentifier keyspace) {
stateEventFilter.start();
Collection<Node> nodes =
context.getMetadataManager().getMetadata().getNodes().values();
- List<CompletionStage<ChannelPool>> poolStages = new
ArrayList<>(nodes.size());
+ Map<Node, CompletionStage<ChannelPool>> poolStageByNode = new
HashMap<>(nodes.size());
Review Comment:
Only reference I could find on this is something I stumbled into in 2019:
https://lists.apache.org/thread/91cvsrg33tgsqh9jhqckxkhsn3z6zy7j
This code also seems problematic and I think we should probably do away with
it in favor of creating a new `Node` every time instead of copying it from the
contact point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
