tolbertam commented on code in PR #2007:
URL: 
https://github.com/apache/cassandra-java-driver/pull/2007#discussion_r1934179026


##########
core/src/main/java/com/datastax/oss/driver/internal/core/session/PoolManager.java:
##########
@@ -221,18 +222,23 @@ private void init(CqlIdentifier keyspace) {
       stateEventFilter.start();
 
       Collection<Node> nodes = 
context.getMetadataManager().getMetadata().getNodes().values();
-      List<CompletionStage<ChannelPool>> poolStages = new 
ArrayList<>(nodes.size());
+      Map<Node, CompletionStage<ChannelPool>> poolStageByNode = new 
HashMap<>(nodes.size());

Review Comment:
   I updated the test to properly provide 
`advanced.address-translator.advertised-hostname` and encountered a new issue 
while building the token map:
   
   ```
   10:08:12.788 [s0-admin-0] WARN  c.d.o.d.i.c.metadata.DefaultMetadata - [s0] 
Unexpected error while refreshing token map, keeping previous version
   java.lang.IllegalArgumentException: Multiple entries with same key: 
Murmur3Token(3074457345618258602)=Node(endPoint=/127.0.0.1:9043, 
hostId=36c0b4f5-08dc-4872-8dbc-85242f72568c, hashCode=4194c04f) and 
Murmur3Token(3074457345618258602)=Node(endPoint=/127.0.0.1:9043, 
hostId=36c0b4f5-08dc-4872-8dbc-85242f72568c, hashCode=4194c04f)
        at 
com.datastax.oss.driver.shaded.guava.common.collect.ImmutableMap.conflictException(ImmutableMap.java:382)
        at 
com.datastax.oss.driver.shaded.guava.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:376)
        at 
com.datastax.oss.driver.shaded.guava.common.collect.RegularImmutableMap.checkNoConflictInKeyBucket(RegularImmutableMap.java:249)
        at 
com.datastax.oss.driver.shaded.guava.common.collect.RegularImmutableMap.fromEntryArrayCheckingBucketOverflow(RegularImmutableMap.java:136)
        at 
com.datastax.oss.driver.shaded.guava.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:98)
        at 
com.datastax.oss.driver.shaded.guava.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:579)
        at 
com.datastax.oss.driver.shaded.guava.common.collect.ImmutableMap$Builder.buildOrThrow(ImmutableMap.java:607)
        at 
com.datastax.oss.driver.shaded.guava.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:594)
        at 
com.datastax.oss.driver.internal.core.metadata.token.DefaultTokenMap.buildTokenToPrimaryAndRing(DefaultTokenMap.java:263)
        at 
com.datastax.oss.driver.internal.core.metadata.token.DefaultTokenMap.build(DefaultTokenMap.java:59)
        at 
com.datastax.oss.driver.internal.core.metadata.DefaultMetadata.rebuildTokenMap(DefaultMetadata.java:161)
        at 
com.datastax.oss.driver.internal.core.metadata.DefaultMetadata.withNodes(DefaultMetadata.java:117)
        at 
com.datastax.oss.driver.internal.core.metadata.InitialNodeListRefresh.compute(InitialNodeListRefresh.java:106)
        at 
com.datastax.oss.driver.internal.core.metadata.MetadataManager.apply(MetadataManager.java:519)
        at 
com.datastax.oss.driver.internal.core.metadata.MetadataManager$SingleThreaded.refreshNodes(MetadataManager.java:335)
        at 
com.datastax.oss.driver.internal.core.metadata.MetadataManager$SingleThreaded.access$1700(MetadataManager.java:299)
        at 
com.datastax.oss.driver.internal.core.metadata.MetadataManager.lambda$refreshNodes$1(MetadataManager.java:172)
        at 
java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:642)
        at 
java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:478)
        at 
io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
        at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54)
        at 
io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
        at 
io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at 
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:829)
   ```
   
   looking through the `InitialNodeListRefresh` code to see if there is other 
issue that is reliant on the endpoint instead of host id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to