jahstreet commented on code in PR #2007:
URL:
https://github.com/apache/cassandra-java-driver/pull/2007#discussion_r1934185926
##########
core/src/main/java/com/datastax/oss/driver/internal/core/session/PoolManager.java:
##########
@@ -221,18 +222,23 @@ private void init(CqlIdentifier keyspace) {
stateEventFilter.start();
Collection<Node> nodes =
context.getMetadataManager().getMetadata().getNodes().values();
- List<CompletionStage<ChannelPool>> poolStages = new
ArrayList<>(nodes.size());
+ Map<Node, CompletionStage<ChannelPool>> poolStageByNode = new
HashMap<>(nodes.size());
Review Comment:
You might also wanna check
https://github.com/apache/cassandra-java-driver/blob/4.17.0/core/src/main/java/com/datastax/oss/driver/internal/core/metadata/InitialNodeListRefresh.java#L75-L85,
specifically `#copyInfo` which messes up the Node properties.
On the token info, there is no reason to keep it enabled when all nodes
point to the same address (which is the case for the
FixedHostNameAddressTranslator), which is most probably a load balancer routing
the requests on its own logic. We should somehow hint users on it though,
agree, not nice to just fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
