belliottsmith commented on code in PR #174:
URL: https://github.com/apache/cassandra-accord/pull/174#discussion_r1977291725
##########
accord-core/src/main/java/accord/topology/TopologyManager.java:
##########
@@ -258,12 +290,45 @@ private Epochs(EpochState[] epochs, List<Notifications>
pending, List<FutureEpoc
Invariants.requireArgument(futureEpochs.get(i).epoch ==
futureEpochs.get(i - 1).epoch + 1);
for (int i = 1; i < epochs.length; i++)
Invariants.requireArgument(epochs[i].epoch() == epochs[i -
1].epoch() - 1);
- this.epochs = epochs;
- }
+ int truncateFrom = -1;
Review Comment:
Maybe this can be in a specific method, rather than being imposed in the
constructor? Would perhaps be clearer to invoke it deliberately, even if we do
it in all the same places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
