belliottsmith commented on code in PR #174:
URL: https://github.com/apache/cassandra-accord/pull/174#discussion_r1977289357
##########
accord-core/src/main/java/accord/topology/TopologyManager.java:
##########
@@ -231,8 +254,10 @@ static class Notifications
Ranges closed = Ranges.EMPTY, retired = Ranges.EMPTY;
}
- private static final Epochs EMPTY = new Epochs(new EpochState[0]);
+ private static final Epochs EMPTY = new Epochs(new EpochState[0], new
ArrayList<>(), new ArrayList<>(), -1);
private final long currentEpoch;
+ private final long firstNonEmptyEpoch;
Review Comment:
do we need to precompute this? can we calculate it on the fly? I think we
don't query it often
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
