ifesdjeen commented on code in PR #174:
URL: https://github.com/apache/cassandra-accord/pull/174#discussion_r1982883277
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -411,6 +407,12 @@ public void withEpoch(EpochSupplier epochSupplier,
BiConsumer<Void, Throwable> c
public void withEpoch(long epoch, BiConsumer<Void, Throwable> callback)
{
+ if (epoch < topology.minEpoch())
Review Comment:
I have switched both paths to `atLeast` variant, I personally think this is
what is expected in both cases. Also, `hasEpoch` and `hasEpochAtLeast` are more
or less synonymous, since we already throw retired exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
