belliottsmith commented on code in PR #174:
URL: https://github.com/apache/cassandra-accord/pull/174#discussion_r1982890997
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -411,6 +407,12 @@ public void withEpoch(EpochSupplier epochSupplier,
BiConsumer<Void, Throwable> c
public void withEpoch(long epoch, BiConsumer<Void, Throwable> callback)
{
+ if (epoch < topology.minEpoch())
Review Comment:
We might need to be careful about using retired, or perhaps we at least need
to offer a two param option for messages, as we ask for an earlier epoch than
we actually need - passing the min epoch with expect the node to have witnessed
but executing in a later epoch. This only affects message arrival, so should be
an easy edge case to address by providing the actual intended epoch for testing
against retired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
