dcapwell commented on code in PR #3954:
URL: https://github.com/apache/cassandra/pull/3954#discussion_r1992461781
##########
test/unit/org/apache/cassandra/service/accord/serializers/TopologySerializersTest.java:
##########
@@ -18,29 +18,43 @@
package org.apache.cassandra.service.accord.serializers;
+import java.io.IOException;
+
import org.junit.Test;
import accord.local.Node;
+import accord.utils.AccordGens;
import org.apache.cassandra.config.DatabaseDescriptor;
-import org.apache.cassandra.utils.SerializerTestUtils;
+import org.apache.cassandra.io.Serializers;
+import org.apache.cassandra.io.util.DataOutputBuffer;
+import org.apache.cassandra.utils.AccordGenerators;
+
+import static accord.utils.Property.qt;
public class TopologySerializersTest
{
static
{
- DatabaseDescriptor.toolInitialization();
+ DatabaseDescriptor.clientInitialization();
}
@Test
- public void nodeId()
+ public void nodeId() throws IOException
{
- SerializerTestUtils.assertSerializerIOEquality(new
Node.Id(1234567890), TopologySerializers.nodeId);
+ qt().forAll(AccordGens.nodes()).check(n ->
Serializers.testSerde(TopologySerializers.nodeId, n));
}
@Test
- public void requestScopeTest()
+ public void topology()
{
-
+ @SuppressWarnings({ "resource", "IOResourceOpenedButNotSafelyClosed"
}) DataOutputBuffer output = new DataOutputBuffer();
+ qt().forAll(AccordGenerators.partitioner().flatMap(p ->
AccordGenerators.topologyGen(p))).check(expected -> {
+ AccordGenerators.maybeUpdatePartitioner(expected.ranges());
+ Serializers.testSerde(output, TopologySerializers.topology,
expected);
+
+ for (Node.Id node : expected.nodes())
+ Serializers.testSerde(output, TopologySerializers.topology,
expected.forNode(node));
Review Comment:
serializer didn't properly handle this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
