dcapwell commented on code in PR #3954:
URL: https://github.com/apache/cassandra/pull/3954#discussion_r1992455597
##########
test/unit/org/apache/cassandra/service/accord/AccordConfigurationServiceTest.java:
##########
@@ -218,7 +218,8 @@ public AsyncResult<Void> onTopologyUpdate(Topology
topology, boolean isLoad, boo
}
finally
{
- journal.shutdown();
+ if (journal != null)
Review Comment:
not directly a bug fix... when i broke one serializer the error was lost due
to this NPE. So made it so we don't NPE and get the original error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
