dcapwell commented on code in PR #3954: URL: https://github.com/apache/cassandra/pull/3954#discussion_r1993966311
########## src/java/org/apache/cassandra/utils/UUIDSerializer.java: ########## @@ -35,13 +36,32 @@ public void serialize(UUID uuid, DataOutputPlus out, int version) throws IOExcep out.writeLong(uuid.getLeastSignificantBits()); } + @Override + public void serialize(UUID uuid, DataOutputPlus out) throws IOException + { + out.writeLong(uuid.getMostSignificantBits()); + out.writeLong(uuid.getLeastSignificantBits()); + } + public UUID deserialize(DataInputPlus in, int version) throws IOException Review Comment: i made sure to add `@Overrride` so this method doesn't leak once we actually migrate off IVersionedSerializer. I moved all version methods to call the unversioned methods, so there isn't duplicate now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org