iamaleksey commented on code in PR #3954: URL: https://github.com/apache/cassandra/pull/3954#discussion_r1993799678
########## src/java/org/apache/cassandra/utils/UUIDSerializer.java: ########## @@ -35,13 +36,32 @@ public void serialize(UUID uuid, DataOutputPlus out, int version) throws IOExcep out.writeLong(uuid.getLeastSignificantBits()); } + @Override + public void serialize(UUID uuid, DataOutputPlus out) throws IOException + { + out.writeLong(uuid.getMostSignificantBits()); + out.writeLong(uuid.getLeastSignificantBits()); + } + public UUID deserialize(DataInputPlus in, int version) throws IOException Review Comment: Can delegate to unversioned calls instead of duplicating? But ideally just no longer implementing `IVersionedSerializer` (maybe in a follow-up commit after Accord's been merged). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org