dcapwell commented on code in PR #3995:
URL: https://github.com/apache/cassandra/pull/3995#discussion_r2004386347
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -493,6 +503,45 @@ private static void
validateAnyOrder(ImmutableUniqueList<Symbol> columns, Set<Ro
if (actual.isEmpty()) sb.append("No rows returned");
else sb.append("Missing rows:\n").append(table(columns, missing));
}
+ if (!unexpected.isEmpty() && unexpected.size() == missing.size())
Review Comment:
this is extra human readable validation logic. `null` vs `<empty>` has been
super hard to see from the above output, and the use case i was finding is that
we had the correct rows returned, but 1 or more columns had a difference... so
if this is the case we try to show which columns are off... this was super
useful for detecting consistency issues with `null` and `<empty>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
