dcapwell commented on code in PR #3995:
URL: https://github.com/apache/cassandra/pull/3995#discussion_r2004397629
##########
test/harry/main/org/apache/cassandra/harry/model/ASTSingleTableModel.java:
##########
@@ -731,7 +780,7 @@ private static boolean matches(ByteBuffer value, List<?
extends Expression> cond
for (Expression e : conditions)
{
ByteBuffer expected = eval(e);
- if (expected.equals(value))
+ if (expected != null && expected.equals(value))
Review Comment:
`eval` is now `Nullable` but this code path shouldn't really ever see a
null... maybe if you did something like `[1] - [1]` then we could get a `null`
here... mostly added to be correct and defensive (and intellij yelled at me)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
