dcapwell commented on code in PR #3995:
URL: https://github.com/apache/cassandra/pull/3995#discussion_r2004462017
##########
test/harry/main/org/apache/cassandra/harry/model/BytesPartitionState.java:
##########
@@ -135,7 +141,13 @@ private long[] toDescriptor(ImmutableUniqueList<Symbol>
positions, Map<Symbol, B
Symbol column = positions.get(i);
if (values.containsKey(column))
{
- long vd = factory.valueCache.deflate(new Value(column.type(),
values.get(column)));
+ ByteBuffer value = values.get(column);
+ if (value == null || !value.hasRemaining() &&
(column.type().isUDT() && column.type().isMultiCell()))
Review Comment:
user type is the only multi cell type i see that allows `<empty>` so this
check should be fine; can expand if we find more cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
