dcapwell commented on code in PR #3995:
URL: https://github.com/apache/cassandra/pull/3995#discussion_r2004463744
##########
test/unit/org/apache/cassandra/cql3/ast/CreateIndexDDL.java:
##########
@@ -141,7 +141,7 @@ else if (((isFrozen(type) && !type.isVector()) ||
StorageAttachedIndex.SUPPORTED
public EnumSet<QueryType> supportedQueries(AbstractType<?> type)
{
type = type.unwrap();
- if (IndexTermType.isEqOnlyType(type))
+ if (IndexTermType.isEqOnlyType(type) || type.isCollection() ||
type.isUDT() || type.isTuple())
Review Comment:
@maedhroz should we push this into `IndexTermType.isEqOnlyType`? Its also
not 100% true as they do support eq for the sub-elements, just not the field as
a whole
##########
test/unit/org/apache/cassandra/cql3/ast/CreateIndexDDL.java:
##########
@@ -141,7 +141,7 @@ else if (((isFrozen(type) && !type.isVector()) ||
StorageAttachedIndex.SUPPORTED
public EnumSet<QueryType> supportedQueries(AbstractType<?> type)
{
type = type.unwrap();
- if (IndexTermType.isEqOnlyType(type))
+ if (IndexTermType.isEqOnlyType(type) || type.isCollection() ||
type.isUDT() || type.isTuple())
Review Comment:
@maedhroz should we push this into `IndexTermType.isEqOnlyType`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
