dcapwell commented on code in PR #3995:
URL: https://github.com/apache/cassandra/pull/3995#discussion_r2004332743
##########
test/distributed/org/apache/cassandra/distributed/test/cql3/SingleNodeTableWalkTest.java:
##########
@@ -88,10 +101,20 @@ protected void preCheck(Cluster cluster,
Property.StatefulBuilder builder)
// CQL_DEBUG_APPLY_OPERATOR = true;
}
- protected TypeGenBuilder supportedTypes()
+ protected TypeGenBuilder supportedTypes(RandomSource rs)
{
- return
AbstractTypeGenerators.withoutUnsafeEquality(AbstractTypeGenerators.builder()
-
.withTypeKinds(AbstractTypeGenerators.TypeKind.PRIMITIVE));
+ return AbstractTypeGenerators.builder()
+
.withTypeKinds(Generators.fromGen(TYPE_KIND_DISTRIBUTION.next(rs)))
+
.withPrimitives(Generators.fromGen(PRIMITIVE_DISTRIBUTION.next(rs)))
+
.withUserTypeFields(AbstractTypeGenerators.UserTypeFieldsGen.simpleNames())
Review Comment:
not testing UDT serialization so simple names makes it so much easier to
read...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
