dcapwell commented on code in PR #4054:
URL: https://github.com/apache/cassandra/pull/4054#discussion_r2029425623
##########
src/java/org/apache/cassandra/cql3/selection/ColumnTimestamps.java:
##########
@@ -385,7 +384,7 @@ public ByteBuffer toByteBuffer(ProtocolVersion
protocolVersion)
List<ByteBuffer> buffers = new ArrayList<>(timestamps.size());
timestamps.forEach(timestamp ->
buffers.add(type.toByteBuffer(timestamp)));
- return LONG_LIST_TYPE.pack(buffers, ByteBufferAccessor.instance);
+ return LONG_LIST_TYPE.pack(buffers);
Review Comment:
this was brought in via rebase, removing to clean up our diff
##########
src/java/org/apache/cassandra/cql3/selection/ListSelector.java:
##########
@@ -102,7 +101,7 @@ public ByteBuffer getOutput(ProtocolVersion protocolVersion)
{
buffers.add(elements.get(i).getOutput(protocolVersion));
}
- return type.pack(buffers, ByteBufferAccessor.instance);
+ return type.pack(buffers);
Review Comment:
this was brought in via rebase, removing to clean up our diff
##########
src/java/org/apache/cassandra/cql3/selection/MapSelector.java:
##########
@@ -218,7 +217,7 @@ public ByteBuffer getOutput(ProtocolVersion protocolVersion)
buffers.add(entry.getKey());
buffers.add(entry.getValue());
}
- return type.pack(buffers, ByteBufferAccessor.instance);
+ return type.pack(buffers);
Review Comment:
this was brought in via rebase, removing to clean up our diff
##########
src/java/org/apache/cassandra/cql3/selection/SetSelector.java:
##########
@@ -104,7 +103,7 @@ public ByteBuffer getOutput(ProtocolVersion protocolVersion)
{
buffers.add(elements.get(i).getOutput(protocolVersion));
}
- return type.pack(new ArrayList<>(buffers),
ByteBufferAccessor.instance);
+ return type.pack(new ArrayList<>(buffers));
Review Comment:
this was brought in via rebase, removing to clean up our diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
