dcapwell commented on code in PR #4054:
URL: https://github.com/apache/cassandra/pull/4054#discussion_r2029428662
##########
test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeTTLOverflowUpgradeTestBase.java:
##########
@@ -77,8 +78,35 @@ enum Step
static volatile long clusterStatupTime = 0;
+ private static class AllowedErrors
+ {
+ private final IntHashSet upgraded = new IntHashSet();
+
+ private void clear()
+ {
+ upgraded.clear();
+ }
+
+ private void upgraded(int node)
+ {
+ upgraded.add(node);
+ }
+
+ private boolean uncaughtExceptionsFilter(int node, Throwable t)
+ {
+ String message = t.getMessage();
+ if (message != null && message.endsWith("In order to avoid this
use a lower TTL, change the expiration date overflow policy or upgrade to a
version where this limitation is fixed. See CASSANDRA-14092 for more details."))
Review Comment:
this test is testing the overflow case of TTL as it was changed, and in
mixed mode this error happens (test covers mixed mode), so need to exclude this
error now.
I got defensive and will fail if the upgraded nodes have this error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
