dcapwell commented on code in PR #4054:
URL: https://github.com/apache/cassandra/pull/4054#discussion_r2029425829
##########
src/java/org/apache/cassandra/cql3/selection/TupleSelector.java:
##########
@@ -103,7 +102,7 @@ public ByteBuffer getOutput(ProtocolVersion
protocolVersion) throws InvalidReque
{
buffers.add(elements.get(i).getOutput(protocolVersion));
}
- return type.pack(buffers, ByteBufferAccessor.instance);
+ return type.pack(buffers);
Review Comment:
this was brought in via rebase, removing to clean up our diff
##########
src/java/org/apache/cassandra/cql3/selection/UserTypeSelector.java:
##########
@@ -198,7 +197,7 @@ public ByteBuffer getOutput(ProtocolVersion protocolVersion)
Selector selector = fields.get(userType.fieldName(i));
buffers.add(selector == null ? null :
selector.getOutput(protocolVersion));
}
- return type.pack(buffers, ByteBufferAccessor.instance);
+ return type.pack(buffers);
Review Comment:
this was brought in via rebase, removing to clean up our diff
##########
src/java/org/apache/cassandra/cql3/selection/VectorSelector.java:
##########
@@ -127,7 +126,7 @@ public ByteBuffer getOutput(ProtocolVersion
protocolVersion) throws InvalidReque
for (int i = 0, m = elements.size(); i < m; i++)
buffers.add(elements.get(i).getOutput(protocolVersion));
- return type.pack(buffers, ByteBufferAccessor.instance);
+ return type.pack(buffers);
Review Comment:
this was brought in via rebase, removing to clean up our diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
