dcapwell commented on code in PR #4054:
URL: https://github.com/apache/cassandra/pull/4054#discussion_r2029427708


##########
test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeBatchTestBase.java:
##########
@@ -62,6 +62,8 @@ protected void testSimpleStrategy(Semver from, Semver to, 
boolean isLogged) thro
         .setup(cluster -> {
             cluster.schemaChange("CREATE KEYSPACE test_simple WITH replication 
= {'class': 'SimpleStrategy', 'replication_factor': 2};");
             cluster.schemaChange("CREATE TABLE test_simple.names (key int 
PRIMARY KEY, name text)");
+            if (isLogged)

Review Comment:
   when logged we cause messages to get dropped which leads to timeouts.  These 
now make it to the cluster error handler which fails the build



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to