maedhroz commented on code in PR #4055:
URL: https://github.com/apache/cassandra/pull/4055#discussion_r2033643874
##########
src/java/org/apache/cassandra/index/sai/disk/StorageAttachedIndexWriter.java:
##########
@@ -126,9 +127,14 @@ public void nextUnfilteredCluster(Unfiltered unfiltered)
if (!unfiltered.isRow())
return;
+ // Ignore rows with no live data...
+ Row row = (Row) unfiltered;
+ if (!row.hasLiveData(FBUtilities.nowInSeconds(), false))
Review Comment:
The only thing I don't like here is having to call `nowInSeconds()` on every
single row...would it be wrong to just cache it when we create the writer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
