maedhroz commented on code in PR #4055:
URL: https://github.com/apache/cassandra/pull/4055#discussion_r2033649442
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndexGroup.java:
##########
@@ -177,16 +177,18 @@ public Index.Indexer indexerFor(Predicate<Index>
indexSelector,
public void insertRow(Row row)
{
// SAI does not index deletions, as these are resolved during
post-filtering.
- if (row.deletion().isLive())
+ if (row.hasLiveData(nowInSec, false))
Review Comment:
`CompositePartitionKeyIndexTest#testIgnoreCellDeletions` should touch this,
but...that particular case is slightly different. If we get past this check
with a cell delete and an actual value, the cell delete is just ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
