dcapwell commented on code in PR #4055:
URL: https://github.com/apache/cassandra/pull/4055#discussion_r2033644194
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndexGroup.java:
##########
@@ -177,16 +177,18 @@ public Index.Indexer indexerFor(Predicate<Index>
indexSelector,
public void insertRow(Row row)
{
// SAI does not index deletions, as these are resolved during
post-filtering.
- if (row.deletion().isLive())
+ if (row.hasLiveData(nowInSec, false))
Review Comment:
did we ever add a test that adds both live data and a tombstone? We want to
index the live data, but ignore the tombstone correct?
##########
CHANGES.txt:
##########
@@ -170,6 +170,7 @@
* Add the ability to disable bulk loading of SSTables (CASSANDRA-18781)
* Clean up obsolete functions and simplify cql_version handling in cqlsh
(CASSANDRA-18787)
Merged from 5.0:
+ * Multiple single-node SAI query bug fixes (CASSANDRA-20338)
Review Comment:
can we get a more detailed message? This file is user facing, so would be
nice to tell users what issues were addressed (in case they need to upgrade)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
