dcapwell commented on code in PR #4055:
URL: https://github.com/apache/cassandra/pull/4055#discussion_r2033664883
##########
src/java/org/apache/cassandra/index/sai/disk/StorageAttachedIndexWriter.java:
##########
@@ -126,9 +127,14 @@ public void nextUnfilteredCluster(Unfiltered unfiltered)
if (!unfiltered.isRow())
return;
+ // Ignore rows with no live data...
+ Row row = (Row) unfiltered;
+ if (!row.hasLiveData(FBUtilities.nowInSeconds(), false))
Review Comment:
there are 2 code paths that i really see that matter
1) index rebuild; the logical `now` can be the start of the rebuild IMO
2) `org.apache.cassandra.io.sstable.format.SortedTableWriter#append` this is
called on flush, we already finished... so `now` being the start of the flush
makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
