dcapwell commented on code in PR #4079:
URL: https://github.com/apache/cassandra/pull/4079#discussion_r2038430306
##########
src/java/org/apache/cassandra/schema/TableId.java:
##########
@@ -58,8 +53,7 @@ public final class TableId implements Comparable<TableId>
{
public static final long MAGIC = 1956074401491665062L;
public static final long EMPTY_SIZE = ObjectSizes.measureDeep(new UUID(0,
0));
-
- private static final ConcurrentHashMap<TableId, TableId> internCache = new
ConcurrentHashMap<>();
Review Comment:
spoke with benedict about this, because we clean up this cache we don't have
the property that `tableA == tableB`, so you *still* need to do
`tableA.equals(tableB)`
He also has a different patch pending that can own this logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
