dcapwell commented on code in PR #4079: URL: https://github.com/apache/cassandra/pull/4079#discussion_r2042597063
########## src/java/org/apache/cassandra/service/paxos/PaxosRequestCallback.java: ########## @@ -45,7 +47,8 @@ public abstract class PaxosRequestCallback<T> extends FailureRecordingCallback<T @Override public void onResponse(Message<T> message) { - ClusterMetadataService.instance().fetchLogFromCMS(message.epoch()); + if (DatabaseDescriptor.getAccordTransactionsEnabled()) Review Comment: when accord isn't enabled, no reason to do these checks ########## src/java/org/apache/cassandra/service/paxos/cleanup/PaxosStartPrepareCleanup.java: ########## @@ -185,7 +186,8 @@ public long serializedSize(Request request, int version) public static IVerbHandler<Request> createVerbHandler(SharedContext ctx) { return in -> { - ClusterMetadataService.instance().fetchLogFromCMS(in.epoch()); + if (DatabaseDescriptor.getAccordTransactionsEnabled()) Review Comment: when accord isn't enabled, no reason to do these checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org