dcapwell commented on code in PR #4079: URL: https://github.com/apache/cassandra/pull/4079#discussion_r2038433031
########## src/java/org/apache/cassandra/tcm/serialization/Version.java: ########## @@ -41,21 +41,29 @@ public enum Version * - Serialize MemtableParams when serializing TableParams */ V2(2), - /** - * - Added AccordFastPath - * - Added ConsensusMigrationState - * - Added AccordStaleReplicas - * - TableParam now has pendingDrop (accord table drop is multistep) + * - down nodes serialized in PrepareCMSReconfiguration */ V3(3), - - // Padding + /** + * - Serialize allowAutoSnapshot and incrementalBackups when serializing TableParams Review Comment: the rebase lost the comments, i added them back. I also found that the spacing wasn't uniform; some versions were 1 space, others were 2 spaces; i made sure each version was consistent (2 spaces to match the first version) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org