dcapwell commented on code in PR #4079:
URL: https://github.com/apache/cassandra/pull/4079#discussion_r2038432559
##########
src/java/org/apache/cassandra/service/accord/txn/TxnReference.java:
##########
@@ -194,7 +194,7 @@ public ByteBuffer getFrozenFieldValue(Cell<?> udt)
{
UserType userType = (UserType) column.type;
int field = ByteBufferUtil.getUnsignedShort(path.get(0), 0);
- return userType.unpack(udt.buffer(),
ByteBufferAccessor.instance).get(field);
+ return userType.unpack(udt.buffer()).get(field);
Review Comment:
when i did the last rebase this change got added else the history got too
hard to work with; so rolling back
##########
src/java/org/apache/cassandra/service/paxos/PaxosRequestCallback.java:
##########
@@ -71,10 +72,6 @@ protected <I> void executeOnSelf(I parameter, BiFunction<I,
InetAddressAndPort,
onResponse(response, getBroadcastAddressAndPort());
}
- public interface TriFunction<A, B, C, D> {
Review Comment:
the interface already exists in utils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
