aratno commented on code in PR #4118:
URL: https://github.com/apache/cassandra/pull/4118#discussion_r2066986183
##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -1602,7 +1596,7 @@ private void doCleanupOne(final ColumnFamilyStore cfs,
CompactionIterator ci = new
CompactionIterator(OperationType.CLEANUP, Collections.singletonList(scanner),
controller, nowInSec, nextTimeUUID(), active, null))
{
StatsMetadata metadata = sstable.getSSTableMetadata();
- writer.switchWriter(createWriter(cfs, compactionFileLocation,
expectedBloomFilterSize, metadata.repairedAt, metadata.pendingRepair,
metadata.isTransient, sstable, txn));
+ writer.switchWriter(createWriter(cfs, compactionFileLocation,
expectedBloomFilterSize, metadata.repairedAt, metadata.pendingRepair,
metadata.isTransient, metadata.mutationIdRanges, sstable, txn));
Review Comment:
When we run cleanup, each modified SSTable should have its previously-owned
mutations purged, and its metadata for previously-owned CoordinatorLogs purged.
I've added a note here to update cleanup, but this path depends on support for
ownership changes, which will come a bit later. I expect we'll have moving
nodes announce that the Shard for the impacted Range is sealed, produce a new
Shard for their new Range, and allocate new CoordinatorLogIds for their updated
Shards. Then, future cleanups can check that any stale CoordinatorLogIds are
purged from SSTable StatsMetadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
