aratno commented on code in PR #4118:
URL: https://github.com/apache/cassandra/pull/4118#discussion_r2067067477
##########
src/java/org/apache/cassandra/io/sstable/metadata/MetadataCollector.java:
##########
@@ -100,6 +92,7 @@ public static StatsMetadata defaultStatsMetadata()
null,
false,
true,
+ MutationIdRanges.NONE,
Review Comment:
Thought about this some more - I think we should not tolerate missing
StatsMetadata files anymore and log a warning. This tolerance was added ~12
years ago for the 2.1 beta when StatsMetadata was introduced, but every
supported upgrade path now should have StatsMetadata already present.
For CASSANDRA-20381, we could refuse to mark SSTables as reconciled if they
are for tracked keyspaces and have MutationIdRanges.NONE, since presumably
these SSTables existed before a migration to mutation tracking, and the
migration path should probably do an IR and mark SSTables as repaired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
