aweisberg commented on code in PR #4118:
URL: https://github.com/apache/cassandra/pull/4118#discussion_r2078055439
##########
src/java/org/apache/cassandra/db/memtable/ShardedSkipListMemtable.java:
##########
@@ -351,7 +357,7 @@ static class MemtableShard
private final ColumnsCollector columnsCollector;
private final StatsCollector statsCollector;
- private final MutationIdCollector mutationIdCollector;
+ private final MutableCoordinatorLogBoundaries coordinatorLogBoundaries
= new MutableCoordinatorLogBoundaries();
Review Comment:
This is used mutably and then needs to be effectively immutable. The mutable
reference should be set to `null` before it is used in a way that needs it to
be immutable. So have a reference to the immutable version with private
visibility and a reference to the mutable version and a getter for the
immutable version that will null out the mutable version when it is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
