aratno commented on code in PR #4118:
URL: https://github.com/apache/cassandra/pull/4118#discussion_r2066991685
##########
test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterTest.java:
##########
@@ -1412,10 +1412,10 @@ private void testNotifySSTableFinished(boolean sorted,
boolean closeWriterOnFirs
}
CQLSSTableWriter writer = builder.build();
- int rowCount = 30_000;
+ final long MiB_1_17 = 1_226_833;
// Max SSTable size is 1 MiB
- // 30_000 rows should take 30_000 * (4 + 37) = 1.17 MiB > 1 MiB, i.e.
producing 2 sstables
- for (int i = 0; i < rowCount; i++)
+ // write 1.17 MiB of data, producing 2 sstables
+ for (int i = 0; writer.bytesWritten() < MiB_1_17; i++)
Review Comment:
It's a test fix Blake included in his draft of the branch:
https://github.com/bdeggleston/cassandra/commit/87e3053f08b03421b834c1f591f5b8bc2121e77c#diff-3ecc75d6d594409c930ba1caa68ace813a00f3d17820b2b338d52b4397c3c4f3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
