aratno commented on code in PR #4118:
URL: https://github.com/apache/cassandra/pull/4118#discussion_r2085674916
##########
src/java/org/apache/cassandra/db/memtable/ShardedSkipListMemtable.java:
##########
@@ -351,7 +357,7 @@ static class MemtableShard
private final ColumnsCollector columnsCollector;
private final StatsCollector statsCollector;
- private final MutationIdCollector mutationIdCollector;
+ private final MutableCoordinatorLogBoundaries coordinatorLogBoundaries
= new MutableCoordinatorLogBoundaries();
Review Comment:
Discussed over Slack - shards are internal to the memtable implementations,
we don't have any special handling for flushing of a single shard. On flush, a
new memtable is made available for new writes, existing writes are given time
to finish up, then are sealed to be flushed. No special handling required for
sharded memtables and per-disk flushes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
