aratno commented on code in PR #4118:
URL: https://github.com/apache/cassandra/pull/4118#discussion_r2080450500
##########
src/java/org/apache/cassandra/db/memtable/ShardedSkipListMemtable.java:
##########
@@ -351,7 +357,7 @@ static class MemtableShard
private final ColumnsCollector columnsCollector;
private final StatsCollector statsCollector;
- private final MutationIdCollector mutationIdCollector;
+ private final MutableCoordinatorLogBoundaries coordinatorLogBoundaries
= new MutableCoordinatorLogBoundaries();
Review Comment:
The number of memtable shards for ShardedSkipListMemtable is
user-configurable, defaults to match the number of cores, and has no
requirement to align with the number of data_file_directories configured for a
node. If a part of a shard is flushed (due to more data_file_directories
configured than memtable shards), then we don't want to switch this to
immutable - the rest of shard can still receive writes while the flush is
happening or after, and we can't reject those updates to the shard's boundaries.
We make a fresh copy of the shard's boundaries when preparing the flush set,
and that copy is immutable between the construction of the flush set and
completion of the flush.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
